Make Hessian sparsity detection work with SCT (prototype)#198
Conversation
|
@gdalle Are you are of way to incorporate your ideas in a new pull request and explicitly mark you as a contributor ? The idea comes from you, so I would like you to appear as a contributor on the github page! Maybe just a dummy commit in the other PR? |
|
Thanks for being so thoughtful about contributors! |
|
Yes great idea, I'll do this. edit: maybe not. Many commits that I wrote in |
|
Closing in favor of #202 that uses cherry-picking |
|
Just so you know, we're still planning on merging adrhill/SparseConnectivityTracer.jl#243, it's just a bit more complicated than we thought because it interferes with array-level overloads (essentially if we regard matrices or vectors of constants as black boxes in SCT, then we can't cherry-pick the non-zero coefficients) |
This is just an example showing how to replace certain dense matrices with sparse ones to turn accidental zeros into structural zeros. This is enough to make the MWE of #193 work with SCT, but I haven't run wider tests, and I don't think you should merge this PR without a deeper reflection on structural sparsity handling